fix: use full path in the enrollment failure urls #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enrollment failure URLs were using the React Router's location.pathname, which omits the basename when the MFE is deployed in a sub-directory. This commit instead uses the global.location.pathname (browser location api) to make sure that the full path including the sub-directory is used.
|
Included in #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enrollment failure URLs were using the React Router's location.pathname, which omits the basename when the MFE is deployed in a sub-directory. This commit instead uses the global.location.pathname (browser location api) to make sure that the full path including the sub-directory is used.
Screenshot showing the different between the 2 location objects
For all changes
Only if submitting a visual change